[libcxx-commits] [libcxx] [libc++] Remove _LIBCPP_SHORT_WCHAR (PR #207562)

[Nikolas Klauser via libcxx-commits]

philnik777 wrote:

> I think this patch needs to come with some documentation change to reflect what we've said in #195149. I also don't really feel like that discussion has a clear conclusion.
> 
> In [#195149 (comment)](https://github.com/llvm/llvm-project/issues/195149#issuecomment-4833887783), Aaron pointed out that we have additional UB in the library (and I think he's right). Before we actually make a move like this, perhaps we should close that loop?

I'm not sure how these are related? AFAICT this patch and the issue are completely orthogonal. This patch simply changes how we detect whether we have a short `wchar_t`. It doesn't change anything w.r.t. our support for `-fshort-wchar`. We can still detect short `wchar_t`s if want to, either through some special compiler-provided feature, or by defining something in `__config_site`.

https://github.com/llvm/llvm-project/pull/207562