[libcxx-commits] [libcxx] [libc++][test] Disable test coverage for `_BitInt` for MSVC STL (PR #212435)

[via libcxx-commits]

llvmorg-github-actions[bot] wrote:


<!--LLVM PR SUMMARY COMMENT-->

@llvm/pr-subscribers-libcxx

Author: A. Jiang (frederick-vs-ja)

<details>
<summary>Changes</summary>

Currently, MSVC STL has no plan to support `_BitInt`. However, when using Clang with MSVC STL, `TEST_HAS_BITINT` is currently `1` as the condition only detects compiler support of `_BitInt`.

This patch disables `_BitInt` coverage for MSVC STL for now.

---
Full diff: https://github.com/llvm/llvm-project/pull/212435.diff


1 Files Affected:

- (modified) libcxx/test/support/test_macros.h (+2-1) 


``````````diff
diff --git a/libcxx/test/support/test_macros.h b/libcxx/test/support/test_macros.h
index 78b1f6eda6576..d9bca7e018e2a 100644
--- a/libcxx/test/support/test_macros.h
+++ b/libcxx/test/support/test_macros.h
@@ -45,7 +45,8 @@
 // _BitInt(N) is a C23 standard feature and a Clang extension in earlier C and C++.
 // __BITINT_MAXWIDTH__ is the portable probe: defined by every compiler that accepts _BitInt.
 // Note __has_extension(bit_int) is unusable because it is not recognized by Clang and produces 0.
-#ifdef __BITINT_MAXWIDTH__
+// Currently, MSVC STL has no plan to support _BitInt(N). So we should not enable test coverage for it.
+#if defined(__BITINT_MAXWIDTH__) && !defined(_MSVC_STL_VERSION)
 #  define TEST_HAS_BITINT 1
 #else
 #  define TEST_HAS_BITINT 0

``````````

</details>


https://github.com/llvm/llvm-project/pull/212435