[libcxx-commits] [libcxx] [libc++] Implement LWG3133: Modernizing numeric type requirements (PR #208145)

[Yordan Vásquez via libcxx-commits]

vyordan wrote:

> I'm sorry... I'm a still afraid of the `static_assert`'s as stricter diagnostics are not the part of LWG3113.
> 
> I think it's less controversial to move the `static_assert`'s and related tests to another PR and leave this PR only adding test for LWG3113 and marking implementation status.

@frederick-vs-ja 
No problem — that makes sense, and I agree the diagnostic is worth debating separately from closing out the issue itself.

To confirm the split: I'll move *all* the static_assert work (both the object+cv-unqualified check and the later Cpp17-named-requirements version, in both complex and valarray) plus their two .verify.cpp tests to a new PR. This PR will keep only the CSV status update and the operator_hijacker tests in valarray's access.pass.cpp/const_access.pass.cpp, since those test the [valarray.access] addressof wording change directly, without introducing any new diagnostic.

Given that, should the CSV status here be |Nothing To Do| rather than |Complete|, since without the static_assert there's no actual implementation change — just a wording update?

https://github.com/llvm/llvm-project/pull/208145