[libcxx-commits] [libcxxabi] [libc++abi][NFC] Remove some XFAILs which never trigger (PR #211241)

[via libcxx-commits]

llvmorg-github-actions[bot] wrote:


<!--LLVM PR SUMMARY COMMENT-->

@llvm/pr-subscribers-libcxxabi

Author: Nikolas Klauser (philnik777)

<details>
<summary>Changes</summary>

The oldest library we support is from LLVM 12, so we can remove any XFAILs for libraries built before that.


---
Full diff: https://github.com/llvm/llvm-project/pull/211241.diff


4 Files Affected:

- (modified) libcxxabi/test/cxa_vec_new_overflow_PR41395.pass.cpp (-3) 
- (modified) libcxxabi/test/dynamic_cast.pass.cpp (-3) 
- (modified) libcxxabi/test/test_aux_runtime_op_array_new.pass.cpp (-4) 
- (modified) libcxxabi/test/uncaught_exceptions.pass.cpp (-3) 


``````````diff
diff --git a/libcxxabi/test/cxa_vec_new_overflow_PR41395.pass.cpp b/libcxxabi/test/cxa_vec_new_overflow_PR41395.pass.cpp
index 746dbaad053ef..fa168e105e78e 100644
--- a/libcxxabi/test/cxa_vec_new_overflow_PR41395.pass.cpp
+++ b/libcxxabi/test/cxa_vec_new_overflow_PR41395.pass.cpp
@@ -8,9 +8,6 @@
 
 // UNSUPPORTED: no-exceptions
 
-// This test requires the fix in http://llvm.org/PR41395 (c4225e124f9e).
-// XFAIL: using-built-library-before-llvm-9
-
 #include "cxxabi.h"
 #include <cassert>
 #include <cstddef>
diff --git a/libcxxabi/test/dynamic_cast.pass.cpp b/libcxxabi/test/dynamic_cast.pass.cpp
index b144e8c06bc5f..143a4bbe135f9 100644
--- a/libcxxabi/test/dynamic_cast.pass.cpp
+++ b/libcxxabi/test/dynamic_cast.pass.cpp
@@ -6,9 +6,6 @@
 //
 //===----------------------------------------------------------------------===//
 
-// This test requires PR33425, PR33487 and PR33439.
-// XFAIL: using-built-library-before-llvm-9
-
 #include <cassert>
 
 // This test explicitly tests dynamic cast with types that have inaccessible
diff --git a/libcxxabi/test/test_aux_runtime_op_array_new.pass.cpp b/libcxxabi/test/test_aux_runtime_op_array_new.pass.cpp
index 3b4cea02012dd..76033307bd5b6 100644
--- a/libcxxabi/test/test_aux_runtime_op_array_new.pass.cpp
+++ b/libcxxabi/test/test_aux_runtime_op_array_new.pass.cpp
@@ -8,10 +8,6 @@
 
 // UNSUPPORTED: no-exceptions
 
-// ___cxa_throw_bad_array_new_length is re-exported from libc++ only starting
-// in LLVM 9.
-// XFAIL: using-built-library-before-llvm-9
-
 #include <cxxabi.h>
 #include <new>
 
diff --git a/libcxxabi/test/uncaught_exceptions.pass.cpp b/libcxxabi/test/uncaught_exceptions.pass.cpp
index d1074616386be..758e7a1b7979c 100644
--- a/libcxxabi/test/uncaught_exceptions.pass.cpp
+++ b/libcxxabi/test/uncaught_exceptions.pass.cpp
@@ -8,9 +8,6 @@
 
 // UNSUPPORTED: no-exceptions
 
-// __cxa_uncaught_exceptions is not re-exported from libc++ until LLVM 9.
-// XFAIL: using-built-library-before-llvm-9
-
 #include <cxxabi.h>
 #include <cassert>
 

``````````

</details>


https://github.com/llvm/llvm-project/pull/211241