[libcxx-commits] [libcxx] [libc++][chrono] Implement LWG 4274: Allow chrono::hh_mm_ss to be constructed from unsigned durations (PR #209686)

[via libcxx-commits]

github-actions[bot] wrote:

<!--LLVM CODE FORMAT COMMENT: {clang-format}-->


:warning: C/C++ code formatter, clang-format found issues in your code. :warning:

<details>
<summary>
You can test this locally with the following command:
</summary>

``````````bash
git-clang-format --diff origin/main HEAD --extensions h,cpp -- libcxx/include/__chrono/hh_mm_ss.h libcxx/test/std/time/time.hms/time.hms.members/hours.pass.cpp libcxx/test/std/time/time.hms/time.hms.members/is_negative.pass.cpp libcxx/test/std/time/time.hms/time.hms.members/minutes.pass.cpp libcxx/test/std/time/time.hms/time.hms.members/seconds.pass.cpp libcxx/test/std/time/time.hms/time.hms.members/subseconds.pass.cpp libcxx/test/std/time/time.hms/time.hms.members/to_duration.pass.cpp --diff_from_common_commit
``````````

:warning:
The reproduction instructions above might return results for more than one PR
in a stack if you are using a stacked PR workflow. You can limit the results by
changing `origin/main` to the base branch/commit you want to compare against.
:warning:

</details>

<details>
<summary>
View the diff from clang-format here.
</summary>

``````````diff
diff --git a/libcxx/test/std/time/time.hms/time.hms.members/hours.pass.cpp b/libcxx/test/std/time/time.hms/time.hms.members/hours.pass.cpp
index 07f2d9c72..2e7e3ab7a 100644
--- a/libcxx/test/std/time/time.hms/time.hms.members/hours.pass.cpp
+++ b/libcxx/test/std/time/time.hms/time.hms.members/hours.pass.cpp
@@ -47,7 +47,7 @@ int main(int, char**)
     static_assert( check_hours(std::chrono::minutes( 1)) == 0, "");
     static_assert( check_hours(std::chrono::minutes(-1)) == 0, "");
 
-    static_assert( check_hours(std::chrono::duration<unsigned, std::milli>(123456789)) == 34, "");
+    static_assert(check_hours(std::chrono::duration<unsigned, std::milli>(123456789)) == 34, "");
 
     assert( check_hours(std::chrono::seconds( 5000)) == 1);
     assert( check_hours(std::chrono::seconds(-5000)) == 1);
diff --git a/libcxx/test/std/time/time.hms/time.hms.members/minutes.pass.cpp b/libcxx/test/std/time/time.hms/time.hms.members/minutes.pass.cpp
index b1a813bad..2fa1150b5 100644
--- a/libcxx/test/std/time/time.hms/time.hms.members/minutes.pass.cpp
+++ b/libcxx/test/std/time/time.hms/time.hms.members/minutes.pass.cpp
@@ -38,7 +38,7 @@ int main(int, char**)
     static_assert( check_minutes(std::chrono::minutes( 1)) == 1, "");
     static_assert( check_minutes(std::chrono::minutes(-1)) == 1, "");
 
-    static_assert( check_minutes(std::chrono::duration<unsigned, std::milli>(123456789)) == 17, "");
+    static_assert(check_minutes(std::chrono::duration<unsigned, std::milli>(123456789)) == 17, "");
 
     assert( check_minutes(std::chrono::seconds( 5000)) == 23);
     assert( check_minutes(std::chrono::seconds(-5000)) == 23);
diff --git a/libcxx/test/std/time/time.hms/time.hms.members/seconds.pass.cpp b/libcxx/test/std/time/time.hms/time.hms.members/seconds.pass.cpp
index 153918f5f..13d5f3c31 100644
--- a/libcxx/test/std/time/time.hms/time.hms.members/seconds.pass.cpp
+++ b/libcxx/test/std/time/time.hms/time.hms.members/seconds.pass.cpp
@@ -39,7 +39,7 @@ int main(int, char**)
     static_assert( check_seconds(std::chrono::seconds( 1)) == 1, "");
     static_assert( check_seconds(std::chrono::seconds(-1)) == 1, "");
 
-    static_assert( check_seconds(std::chrono::duration<unsigned, std::milli>(123456789)) == 36, "");
+    static_assert(check_seconds(std::chrono::duration<unsigned, std::milli>(123456789)) == 36, "");
 
     assert( check_seconds(std::chrono::seconds( 5000)) == 20);
     assert( check_seconds(std::chrono::seconds(-5000)) == 20);
diff --git a/libcxx/test/std/time/time.hms/time.hms.members/subseconds.pass.cpp b/libcxx/test/std/time/time.hms/time.hms.members/subseconds.pass.cpp
index 00b4a5db2..03cc15de9 100644
--- a/libcxx/test/std/time/time.hms/time.hms.members/subseconds.pass.cpp
+++ b/libcxx/test/std/time/time.hms/time.hms.members/subseconds.pass.cpp
@@ -39,7 +39,7 @@ int main(int, char**)
     static_assert( check_subseconds(std::chrono::seconds( 1)) == 0, "");
     static_assert( check_subseconds(std::chrono::seconds(-1)) == 0, "");
 
-    static_assert( check_subseconds(std::chrono::duration<unsigned, std::milli>(123456789)) == 789, "");
+    static_assert(check_subseconds(std::chrono::duration<unsigned, std::milli>(123456789)) == 789, "");
 
     assert( check_subseconds(std::chrono::seconds( 5000)) == 0);
     assert( check_subseconds(std::chrono::seconds(-5000)) == 0);
diff --git a/libcxx/test/std/time/time.hms/time.hms.members/to_duration.pass.cpp b/libcxx/test/std/time/time.hms/time.hms.members/to_duration.pass.cpp
index f6817b48d..9b77d3a28 100644
--- a/libcxx/test/std/time/time.hms/time.hms.members/to_duration.pass.cpp
+++ b/libcxx/test/std/time/time.hms/time.hms.members/to_duration.pass.cpp
@@ -39,7 +39,7 @@ int main(int, char**)
     static_assert( check_duration(std::chrono::minutes( 1)) ==  60, "");
     static_assert( check_duration(std::chrono::minutes(-1)) == -60, "");
 
-    static_assert( check_duration(std::chrono::duration<unsigned, std::milli>(123456789)) == 123456789, "");
+    static_assert(check_duration(std::chrono::duration<unsigned, std::milli>(123456789)) == 123456789, "");
 
     assert( check_duration(std::chrono::seconds( 5000)) ==    5000LL);
     assert( check_duration(std::chrono::seconds(-5000)) ==   -5000LL);

``````````

</details>


https://github.com/llvm/llvm-project/pull/209686