[libcxx-commits] [libcxx] [libc++] Remove some unnecessary functions from __vector_layout (PR #207152)

[Louis Dionne via libcxx-commits]

ldionne wrote:

> The changes in this patch undo some very delicate fine-tuning that I did in #155330.

Can you explain? When I reviewed this with Nikolas he explained that he looked at the codegen and all of these are exactly the same after the first InstCombine pass. If that's not the case, then perhaps a revert is mandated, but let's discuss the technical concerns with it.

> I'm disappointed that I wasn't asked to review this patch before merging.

Unless mistaken, you are notified on libc++ PRs, so I'm not certain what your expectation was. I don't think it's realistic to put you on the critical path for every vector change going forward since you landed the size-based vector patch.

https://github.com/llvm/llvm-project/pull/207152