[libcxx-commits] [libcxx] [libc++][NFC] Inline std::function members into the class body (PR #209461)

[David Spickett via libcxx-commits]

DavidSpickett wrote:

There is an lldb test failing in GitHub CI since this change:
```
Script:
--
/usr/bin/python3 /__w/llvm-project/llvm-project/lldb/test/API/dotest.py -u CXXFLAGS -u CFLAGS --env LLVM_LIBS_DIR=/__w/llvm-project/llvm-project/build/./lib --env LLVM_INCLUDE_DIR=/__w/llvm-project/llvm-project/build/include --env LLVM_TOOLS_DIR=/__w/llvm-project/llvm-project/build/./bin --libcxx-include-dir /__w/llvm-project/llvm-project/build/include/c++/v1 --libcxx-include-target-dir /__w/llvm-project/llvm-project/build/include/aarch64-unknown-linux-gnu/c++/v1 --libcxx-library-dir /__w/llvm-project/llvm-project/build/./lib/aarch64-unknown-linux-gnu --triple aarch64-unknown-linux-gnu --build-dir /__w/llvm-project/llvm-project/build/lldb-test-build --lldb-module-cache-dir /__w/llvm-project/llvm-project/build/lldb-test-build/module-cache-lldb/lldb-api --clang-module-cache-dir /__w/llvm-project/llvm-project/build/lldb-test-build/module-cache-clang/lldb-api --executable /__w/llvm-project/llvm-project/build/./bin/lldb --lldb-python-dir /__w/llvm-project/llvm-project/build/local/lib/python3.12/dist-packages --compiler /__w/llvm-project/llvm-project/build/./bin/clang --dsymutil /__w/llvm-project/llvm-project/build/./bin/dsymutil --make /usr/bin/gmake --llvm-tools-dir /__w/llvm-project/llvm-project/build/./bin --lldb-obj-root /__w/llvm-project/llvm-project/build/tools/lldb --lldb-libs-dir /__w/llvm-project/llvm-project/build/./lib --cmake-build-type Release /__w/llvm-project/llvm-project/lldb/test/API/lang/cpp/std-function-step-into-callable -p TestStdFunctionStepIntoCallable.py
--
Exit Code: 1

Command Output (stdout):
--
Skipping the following test categories: msvcstl, dsym, pdb, gmodules, debugserver, objc

--
Command Output (stderr):
--
FAIL: LLDB (/__w/llvm-project/llvm-project/build/bin/clang-aarch64) :: test (TestStdFunctionStepIntoCallable.LibCxxFunctionSteppingIntoCallableTestCase.test)
Log Files:
 - /__w/llvm-project/llvm-project/build/lldb-test-build/lang/cpp/std-function-step-into-callable/TestStdFunctionStepIntoCallable/Failure_test.log
======================================================================
FAIL: test (TestStdFunctionStepIntoCallable.LibCxxFunctionSteppingIntoCallableTestCase.test)
   Test that std::function as defined by libc++ is correctly printed by LLDB
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/__w/llvm-project/llvm-project/lldb/test/API/lang/cpp/std-function-step-into-callable/TestStdFunctionStepIntoCallable.py", line 54, in test
    self.assertEqual(
AssertionError: 32 != 4
Config=aarch64-/__w/llvm-project/llvm-project/build/bin/clang
----------------------------------------------------------------------
Ran 1 test in 0.293s

FAILED (failures=1)

--
```
We expect to see that we're inside of a function, but we're still in main where the function is being called. Not sure what is wrong yet, mostly likely an lldb assumption at fault.

https://github.com/llvm/llvm-project/pull/209461