[libcxx-commits] [libcxx] [libc++] Remove {Pause, Resume}Timing from fast push_back benchmarks (PR #209130)

[via libcxx-commits]

llvmorg-github-actions[bot] wrote:


<!--LLVM PR SUMMARY COMMENT-->

@llvm/pr-subscribers-libcxx

Author: Nikolas Klauser (philnik777)

<details>
<summary>Changes</summary>

These benchmarks are expected to run for a very short time, and `{Pause,Resume}Timing` should only be used when operations are expected to take a long time. Removing them reduces the amount of noise in these benchmarks.

Fixes #<!-- -->208719

---
Full diff: https://github.com/llvm/llvm-project/pull/209130.diff


1 Files Affected:

- (modified) libcxx/test/benchmarks/containers/sequence/sequence_container_benchmarks.h (-4) 


``````````diff
diff --git a/libcxx/test/benchmarks/containers/sequence/sequence_container_benchmarks.h b/libcxx/test/benchmarks/containers/sequence/sequence_container_benchmarks.h
index 92346c38563fb..630da0dd62bd2 100644
--- a/libcxx/test/benchmarks/containers/sequence/sequence_container_benchmarks.h
+++ b/libcxx/test/benchmarks/containers/sequence/sequence_container_benchmarks.h
@@ -372,9 +372,7 @@ void sequence_container_benchmarks(std::string container) {
             }
             DoNotOptimizeData(c);
 
-            st.PauseTiming();
             c.erase(c.end() - BatchSize, c.end());
-            st.ResumeTiming();
           }
         });
     }
@@ -395,9 +393,7 @@ void sequence_container_benchmarks(std::string container) {
           }
           DoNotOptimizeData(c);
 
-          st.PauseTiming();
           c.clear();
-          st.ResumeTiming();
         }
       });
 

``````````

</details>


https://github.com/llvm/llvm-project/pull/209130