[libcxx-commits] [libcxx] [libc++] Remove {Pause, Resume}Timing from fast push_back benchmarks (PR #209130)

Nikolas Klauser via libcxx-commits libcxx-commits at lists.llvm.org
Mon Jul 13 03:07:16 PDT 2026


https://github.com/philnik777 created https://github.com/llvm/llvm-project/pull/209130

These benchmarks are expected to run for a very short time, and `{Pause,Resume}Timing` should only be used when operations are expected to take a long time. This reduces the amount of noise in these benchmarks.


>From d718244680aa3db8a36c88204fa78bc256ff5267 Mon Sep 17 00:00:00 2001
From: Nikolas Klauser <nikolasklauser at berlin.de>
Date: Mon, 13 Jul 2026 12:05:58 +0200
Subject: [PATCH] [libc++] Remove {Pause,Resume}Timing from fast push_back
 benchmarks

---
 .../containers/sequence/sequence_container_benchmarks.h       | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/libcxx/test/benchmarks/containers/sequence/sequence_container_benchmarks.h b/libcxx/test/benchmarks/containers/sequence/sequence_container_benchmarks.h
index 92346c38563fb..630da0dd62bd2 100644
--- a/libcxx/test/benchmarks/containers/sequence/sequence_container_benchmarks.h
+++ b/libcxx/test/benchmarks/containers/sequence/sequence_container_benchmarks.h
@@ -372,9 +372,7 @@ void sequence_container_benchmarks(std::string container) {
             }
             DoNotOptimizeData(c);
 
-            st.PauseTiming();
             c.erase(c.end() - BatchSize, c.end());
-            st.ResumeTiming();
           }
         });
     }
@@ -395,9 +393,7 @@ void sequence_container_benchmarks(std::string container) {
           }
           DoNotOptimizeData(c);
 
-          st.PauseTiming();
           c.clear();
-          st.ResumeTiming();
         }
       });
 



More information about the libcxx-commits mailing list