[libcxx-commits] [libcxx] [libcxx] avoid include Uppercase windows headers (PR #208903)

[via libcxx-commits]

llvmorg-github-actions[bot] wrote:


<!--LLVM PR SUMMARY COMMENT-->

@llvm/pr-subscribers-libcxx

Author: cqwrteur (trcrsired)

<details>
<summary>Changes</summary>

We should use unknwn.h and windows.h instead of Unknwn.h and Windows.h because Linux and other non‑Windows systems treat filenames as case‑sensitive. Windows does not, so mixed‑case includes work there but break elsewhere. Both mingw‑w64‑crt and windows‑msvc‑sysroot provide all Windows headers in fully lowercase, so using the lowercase forms ensures consistent cross‑platform builds.

#<!-- -->208901

---
Full diff: https://github.com/llvm/llvm-project/pull/208903.diff


1 Files Affected:

- (modified) libcxx/src/support/runtime/exception_pointer_msvc.ipp (+2-2) 


``````````diff
diff --git a/libcxx/src/support/runtime/exception_pointer_msvc.ipp b/libcxx/src/support/runtime/exception_pointer_msvc.ipp
index 72360a2d791bd..3102d1ee93db2 100644
--- a/libcxx/src/support/runtime/exception_pointer_msvc.ipp
+++ b/libcxx/src/support/runtime/exception_pointer_msvc.ipp
@@ -14,8 +14,8 @@ _LIBCPP_CLANG_DIAGNOSTIC_IGNORED("-Wmultichar")
 #include <cstdlib>
 #include <cstring>
 
-#include <Unknwn.h>
-#include <Windows.h>
+#include <unknwn.h>
+#include <windows.h>
 struct _ThrowInfo;
 #include <eh.h>
 #include <ehdata.h>

``````````

</details>


https://github.com/llvm/llvm-project/pull/208903