[libcxx-commits] [libcxx] [libc++] Implement LWG3133: Modernizing numeric type requirements (PR #208145)

[Yordan Vásquez via libcxx-commits]

================
@@ -266,6 +266,9 @@ template<class T> complex<T> tanh (const complex<T>&);
 #  include <__tuple/tuple_element.h>
 #  include <__tuple/tuple_size.h>
 #  include <__type_traits/conditional.h>
+#  include <__type_traits/is_object.h>
+#  include <__type_traits/is_same.h>
----------------
vyordan wrote:

Hello, thank you for the review.
I understood that I should remove `#include <__type_traits/is_same.h>` and `#include <__type_traits/remove_cv.h>`, since they are no longer used

However, my `static_assert` uses `is_object<_Tp>::value`, so I need to keep `#include <__type_traits/is_object.h>` — otherwise the code won't compile.
Could you please clarify whether I should replace `is_object` with some other trait (e.g., `__is_object` or similar), or does `__is_unqualified_v` already cover the "object type" check internally?

Thanks again for your time!

https://github.com/llvm/llvm-project/pull/208145