[libcxx-commits] [libcxx] [libc++] Use std::to_chars to format thread::id and canonicalize the representation across platforms (PR #181624)

[Nikolas Klauser via libcxx-commits]

philnik777 wrote:

> > > This removed some transitive includes, which affected some projects. This isn't a big deal in practice, but if we still have the `_LIBCPP_KEEP_TRANSITIVE_INCLUDES_LLVM23` flag, we probably should cover these headers by that as well? (I wouldn't use it myself, but it would seem consistent to have that flag keep these includes as well.)
> > 
> > 
> > I've added `<sstream>` behind `_LIBCPP_KEEP_TRANSITIVE_INCLUDES_LLVM23` to both `<future>` and `<thread>`. Is there some other header that is removed?
> 
> Oh, sorry - I overlooked the detail that you actually did that in the other headers, not the one that it was removed from. Then it's probably all fine! Sorry for the noise.

No worries! We always put the unused includes in the top-level headers to avoid polluting new headers that use the detail headers.

https://github.com/llvm/llvm-project/pull/181624