[libcxx-commits] [libcxx] [libc++][ranges] Applied [[nodiscard]] to `join_view` (PR #206838)

[Hristo Hristov via libcxx-commits]

Zingam wrote:

> I think it's ready for a round of review, however I'd like to confirm: While looking at the `join_with_view.h` I can see there are internal APIs like `__get_outer()` and so on marked as `nodiscard`. Should I also mark the equivalent in `join_view` as `[[nodiscard]]` as well?

Applying `[[nodiscard]]` to implementation details is out-of-scope. Only in containers we applied it to iterators such as `__wrap_iter` for a reason.

https://github.com/llvm/llvm-project/pull/206838