[libcxx-commits] [libcxxabi] [libc++abi] Always enable -fvisibility=hidden (PR #207333)

[Louis Dionne via libcxx-commits]

================
@@ -195,6 +195,7 @@ if (LIBCXXABI_SUPPORTS_SHARED_LIBRARY)
   # Build with -fsized-deallocation, which is default in recent versions of Clang.
   # TODO(LLVM 21): This can be dropped once we only support Clang >= 19.
   target_add_compile_flags_if_supported(cxxabi_shared_objects PRIVATE -fsized-deallocation)
+  target_add_compile_flags_if_supported(cxxabi_shared_objects PRIVATE -fvisibility=hidden)
----------------
ldionne wrote:

Can you please review the output of `nm` on `libc++abi` to make sure you don't see anything unexpected? My trust in our ABI list mechanism has been shaken recently, see https://github.com/llvm/llvm-project/issues/207409

https://github.com/llvm/llvm-project/pull/207333