[libcxx-commits] [libcxx] [libcxx][libc] update LLVM-libc test status (PR #201236)

[Michael Jones via libcxx-commits]

michaelrj-google wrote:

> Please elaborate? Do you mean that if you _don't_ explicitly add `-latomic` then: (a) `has-1024-bit-atomics` feature check fails because of issue with the Clang driver not linking atomics by default (#73361)? (b) libc++ thinks `has-1024-bit-atomics` is False, and expects tests with 1024-bit atomics to fail. (c) when we actually run such tests, `add-latomic-workaround` feature is activated, adds `-latomic` to the linker flags, and the test works.
> 
> If that's the case, can we just `["-latomic"]` linker flag addition to the `has-64-bit-atomics` and `has-1024-bit-atomics` checks in the test config?
> 
> Why is it related to llvm-libc setup, and doesn't fire elsewhere?

That's correct as far as I understand. We could add `["-latomic"]` to the other checks, as one possible solution.

I'd guess it doesn't cause problems elsewhere because systems either have libatomic available and always want it, or don't have it at all.

https://github.com/llvm/llvm-project/pull/201236