[libcxx-commits] [libcxx] [libc++] Fix naming of benchmarks with new SPEC metrics (PR #178445)
via libcxx-commits
libcxx-commits at lists.llvm.org
Wed Jan 28 07:26:49 PST 2026
llvmbot wrote:
<!--LLVM PR SUMMARY COMMENT-->
@llvm/pr-subscribers-libcxx
Author: Louis Dionne (ldionne)
<details>
<summary>Changes</summary>
We need to ensure that no dots end up in those names to avoid confusing LNT and the compare-benchmarks script.
---
Full diff: https://github.com/llvm/llvm-project/pull/178445.diff
1 Files Affected:
- (modified) libcxx/test/benchmarks/spec.gen.py (+1-1)
``````````diff
diff --git a/libcxx/test/benchmarks/spec.gen.py b/libcxx/test/benchmarks/spec.gen.py
index c08541a57ac7c..41d8032babc3a 100644
--- a/libcxx/test/benchmarks/spec.gen.py
+++ b/libcxx/test/benchmarks/spec.gen.py
@@ -88,5 +88,5 @@
# If there were no errors, parse the SPEC results and the `time` output into LNT-compatible format and print them.
print(f'RUN: %{{libcxx-dir}}/utils/parse-spec-results %{{temp}}/result/*.train.csv --output-format=lnt > %{{temp}}/results.lnt')
- print(f'RUN: %{{libcxx-dir}}/utils/parse-time-output %{{temp}}/time.txt --benchmark {benchmark} --extract instructions max_rss cycles peak_memory >> %{{temp}}/results.lnt')
+ print(f'RUN: %{{libcxx-dir}}/utils/parse-time-output %{{temp}}/time.txt --benchmark {benchmark.replace(".", "_")} --extract instructions max_rss cycles peak_memory >> %{{temp}}/results.lnt')
print(f'RUN: cat %{{temp}}/results.lnt')
``````````
</details>
https://github.com/llvm/llvm-project/pull/178445
More information about the libcxx-commits
mailing list