[libcxx-commits] [libcxx] [libc++] Handle Clang function effect analysis in hardening assertions (PR #177447)

[Louis Dionne via libcxx-commits]

================
@@ -17,11 +17,17 @@
 #  pragma GCC system_header
 #endif
 
+// Note that we disable -Wfunction-effects inside _LIBCPP_ASSERT when the assertion fails since
+// function effect attributes don't provide any guarantees once a function is determined to be
----------------
ldionne wrote:

What Doug said. But I like your rewording, I took it.

https://github.com/llvm/llvm-project/pull/177447