[libcxx-commits] [libcxx] [libc++] Annotate filesystem::path with [[clang::lifetimebound]] (PR #175507)

[Nikolas Klauser via libcxx-commits]

philnik777 wrote:

> > Why do we want to cherry-pick this? It's clearly feature work, which we usually don't cherry-pick.
> 
> I kind of view this as a bug fix since it's making something safer and there's not really any risk associated to it. I could also be convinced otherwise, but I think this passes the bar for cherry-picking.

Since we've not even gotten to RC2 yet I don't really care, but I don't see how this is fixing a bug. Would you cherry-pick adding `[[nodiscard]]` somewhere? If we were after RC3 I'd definitely be against this cherry-pick, since we risk diagnosing correct code (even if it's unlikely).

https://github.com/llvm/llvm-project/pull/175507