[libcxx-commits] [libcxx] [libcxx] sort `_LIBCPP_INTRODUCED_IN_LLVM_<X>` usages in reverse chronological order (PR #176857)
Nikolas Klauser via libcxx-commits
libcxx-commits at lists.llvm.org
Tue Jan 20 02:15:38 PST 2026
philnik777 wrote:
> > AFAICT they were in chronological order before. That doesn't seem "all over the place" to me?
>
> Do you mean in ascending order? v22 did not get ordered correctly, v18-related stuff is split, and v8-related stuff at the end. It's currently: 22 - 12 - 14 - 15 - 16 - 17 - 18a - 19 - 20 - 21 - 18b - 8.
>
> I agree that - now that I've written it down - it's not _that_ all over the place as my initial impression. Still, it doesn't match either the definition order or the "more important (because more recent) things on top", so I think it'd be worth homogenizing.
I agree that the 22 is in the wrong place. The "18b" case is separate because it's exception and rtti special-casing (though arguably this special-casing here is a mess and this block shouldn't exist at all). The "8" case is not part of the normal availability stuff, but part of the minimum header version machinery, so it should be separate.
https://github.com/llvm/llvm-project/pull/176857
More information about the libcxx-commits
mailing list