[libcxx-commits] [libcxx] [libc++] Add parentheses around shift operations in bitwise expressions (PR #175407)

Louis Dionne via libcxx-commits libcxx-commits at lists.llvm.org
Wed Jan 14 14:36:21 PST 2026


================
@@ -60,7 +60,7 @@ void test_encode(OutIt& out_it, char16_t value) {
     *out_it++ = static_cast<char>(0b10000000 | (value & 0b00111111));
   } else {
     *out_it++ = static_cast<char>(0b11100000 | (value >> 12));
-    *out_it++ = static_cast<char>(0b10000000 | ((value) >> 6 & 0b00111111));
+    *out_it++ = static_cast<char>(0b10000000 | ((value >> 6) & 0b00111111));
----------------
ldionne wrote:

This one is a clear improvement.

https://github.com/llvm/llvm-project/pull/175407


More information about the libcxx-commits mailing list