[libcxx-commits] [libcxx] [libc++] Fix use of static in constexpr (PR #175667)

[Prabhu Rajasekaran via libcxx-commits]

Prabhuk wrote:

> I think we had this problem before already, and I'm not a fan of non-NFC patches that aren't tested. We don't care about the warning, so that's not a problem. I'd really like to have a feature request that GCC allows the extension in older language modes. Until we actually have that I'd really like to see a clang-tidy check to make sure we're not regressing on this again.
> 
> If you're not comfortable with adding a clang-tidy check I can do that instead.

Thank you. I am working on a clang-tidy patch. I will upload it as soon as I can for review. Can this patch land to unblock our builders in the meanwhile? Should I mark this patch as NFC as well?

https://github.com/llvm/llvm-project/pull/175667