[libcxx-commits] [libcxx] f8ae051 - [libc++][ranges][NFC] Cleanup `nodiscard.verify.cpp` tests (#175725)

via libcxx-commits libcxx-commits at lists.llvm.org
Tue Jan 13 08:21:12 PST 2026


Author: Hristo Hristov
Date: 2026-01-13T18:21:07+02:00
New Revision: f8ae05130e4672da9bc617883aa74d7f74604ab7

URL: https://github.com/llvm/llvm-project/commit/f8ae05130e4672da9bc617883aa74d7f74604ab7
DIFF: https://github.com/llvm/llvm-project/commit/f8ae05130e4672da9bc617883aa74d7f74604ab7.diff

LOG: [libc++][ranges][NFC] Cleanup `nodiscard.verify.cpp` tests (#175725)

- Removed redundant files
- Renamed files to the common `nodiscard.verify.cpp`

Added: 
    libcxx/test/libcxx/ranges/range.adaptors/range.as_rvalue/nodiscard.verify.cpp
    libcxx/test/libcxx/ranges/range.adaptors/range.common/nodiscard.verify.cpp
    libcxx/test/libcxx/ranges/range.adaptors/range.counted/nodiscard.verify.cpp

Modified: 
    

Removed: 
    libcxx/test/libcxx/ranges/range.adaptors/range.as_rvalue_view/nodiscard.verify.cpp
    libcxx/test/libcxx/ranges/range.adaptors/range.common.view/adaptor.nodiscard.verify.cpp
    libcxx/test/libcxx/ranges/range.adaptors/range.common.view/nodiscard.verify.cpp
    libcxx/test/libcxx/ranges/range.adaptors/range.counted/adaptor.nodiscard.verify.cpp


################################################################################
diff  --git a/libcxx/test/libcxx/ranges/range.adaptors/range.as_rvalue_view/nodiscard.verify.cpp b/libcxx/test/libcxx/ranges/range.adaptors/range.as_rvalue/nodiscard.verify.cpp
similarity index 100%
rename from libcxx/test/libcxx/ranges/range.adaptors/range.as_rvalue_view/nodiscard.verify.cpp
rename to libcxx/test/libcxx/ranges/range.adaptors/range.as_rvalue/nodiscard.verify.cpp

diff  --git a/libcxx/test/libcxx/ranges/range.adaptors/range.common.view/adaptor.nodiscard.verify.cpp b/libcxx/test/libcxx/ranges/range.adaptors/range.common.view/adaptor.nodiscard.verify.cpp
deleted file mode 100644
index bc9d9c90358e4..0000000000000
--- a/libcxx/test/libcxx/ranges/range.adaptors/range.common.view/adaptor.nodiscard.verify.cpp
+++ /dev/null
@@ -1,21 +0,0 @@
-//===----------------------------------------------------------------------===//
-//
-// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
-// See https://llvm.org/LICENSE.txt for license information.
-// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
-//
-//===----------------------------------------------------------------------===//
-
-// UNSUPPORTED: c++03, c++11, c++14, c++17
-
-// Test the libc++ extension that std::views::common is marked as [[nodiscard]].
-
-#include <ranges>
-
-void test() {
-  int range[] = {1, 2, 3};
-
-  std::views::common(range); // expected-warning {{ignoring return value of function declared with 'nodiscard' attribute}}
-  range | std::views::common; // expected-warning {{ignoring return value of function declared with 'nodiscard' attribute}}
-  std::views::all | std::views::common; // expected-warning {{ignoring return value of function declared with 'nodiscard' attribute}}
-}

diff  --git a/libcxx/test/libcxx/ranges/range.adaptors/range.common.view/nodiscard.verify.cpp b/libcxx/test/libcxx/ranges/range.adaptors/range.common/nodiscard.verify.cpp
similarity index 100%
rename from libcxx/test/libcxx/ranges/range.adaptors/range.common.view/nodiscard.verify.cpp
rename to libcxx/test/libcxx/ranges/range.adaptors/range.common/nodiscard.verify.cpp

diff  --git a/libcxx/test/libcxx/ranges/range.adaptors/range.counted/adaptor.nodiscard.verify.cpp b/libcxx/test/libcxx/ranges/range.adaptors/range.counted/nodiscard.verify.cpp
similarity index 100%
rename from libcxx/test/libcxx/ranges/range.adaptors/range.counted/adaptor.nodiscard.verify.cpp
rename to libcxx/test/libcxx/ranges/range.adaptors/range.counted/nodiscard.verify.cpp


        


More information about the libcxx-commits mailing list