[libcxx-commits] [libcxx] [libc++] Refactor std::midpoint tests and add constraint checks (PR #175388)
via libcxx-commits
libcxx-commits at lists.llvm.org
Mon Jan 12 04:46:38 PST 2026
eiytoq wrote:
> > > Currently it's really hard to see what actually changed and what's just formatting. Could you push a separate formatting commit and rebase on top of that?
> >
> >
> > I've rebased this PR. It now consists of a formatting commit followed by the actual logic changes.
>
> Generally: NFC changes like refactoring, including renaming and reformatting are better submitted as a per-requisite as a separate PR. Similar to what we were supposed to do here: #174596 This keeps the PR with the actual changes clean and clear and the changes after merging obvious.
Thanks for the guidance. I have extracted the NFC changes into PR #175531. Once that is merged, I will rebase this PR to contain only the functional changes.
https://github.com/llvm/llvm-project/pull/175388
More information about the libcxx-commits
mailing list