[libcxx-commits] [libcxx] [libc++] Remove _LIBCPP_EXTERN_TEMPLATE_TYPE_VIS and _LIBCPP_CLASS_TEMPLATE_INSTANTIATION_VIS (PR #133704)

[Louis Dionne via libcxx-commits]

================
@@ -382,6 +369,17 @@ typedef __char32_t char32_t;
 #    define _LIBCPP_HIDE_FROM_ABI_AFTER_V1 _LIBCPP_HIDE_FROM_ABI
 #  endif
 
+#  if __has_warning("-Wdllexport-explicit-instantiation")
+#      define _LIBCPP_CLANG_DIAGNOSTIC_IGNORE_DLLEXPORT                                                                \
+        _LIBCPP_CLANG_DIAGNOSTIC_IGNORED("-Wdllexport-explicit-instantiation")
+#  elif defined(_LIBCPP_OBJECT_FORMAT_COFF)
----------------
ldionne wrote:

```suggestion
#  elif defined(_LIBCPP_OBJECT_FORMAT_COFF) // TODO(LLVM 24): Remove this fallback and assume that the warning exists
```

https://github.com/llvm/llvm-project/pull/133704