[libcxx-commits] [libcxx] [libcxx] Add missing member `cend()` to `MinSequenceContainer` (PR #175114)
Vojtěch Michal via libcxx-commits
libcxx-commits at lists.llvm.org
Fri Jan 9 04:07:51 PST 2026
https://github.com/vmichal updated https://github.com/llvm/llvm-project/pull/175114
>From 77193a0d3fe28ee92bd80c3952643624a58cf32f Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Vojt=C4=9Bch=20Michal?= <vojta.michall at email.cz>
Date: Fri, 9 Jan 2026 04:24:39 +0100
Subject: [PATCH 1/2] Add member cend() to the MinSequenceContainer (used by
flat_set/flat_map tests).
---
libcxx/test/support/MinSequenceContainer.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/libcxx/test/support/MinSequenceContainer.h b/libcxx/test/support/MinSequenceContainer.h
index f9e67cd726eb7..721fefccdb6cc 100644
--- a/libcxx/test/support/MinSequenceContainer.h
+++ b/libcxx/test/support/MinSequenceContainer.h
@@ -54,6 +54,7 @@ struct MinSequenceContainer {
TEST_CONSTEXPR_CXX20 const_iterator cbegin() const { return const_iterator(data_.data()); }
TEST_CONSTEXPR_CXX20 iterator end() { return begin() + size(); }
TEST_CONSTEXPR_CXX20 const_iterator end() const { return begin() + size(); }
+ TEST_CONSTEXPR_CXX20 const_iterator cend() const { return begin() + size(); }
TEST_CONSTEXPR_CXX20 size_type size() const { return static_cast<size_type>(data_.size()); }
TEST_CONSTEXPR_CXX20 bool empty() const { return data_.empty(); }
>From dfb5c74b991731f3b2cfdebba06ffc3bbf69eb50 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Vojt=C4=9Bch=20Michal?= <vojta.michall at email.cz>
Date: Fri, 9 Jan 2026 13:06:02 +0100
Subject: [PATCH 2/2] Implement cend() using end() instead of repeating
calculation.
---
libcxx/test/support/MinSequenceContainer.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/libcxx/test/support/MinSequenceContainer.h b/libcxx/test/support/MinSequenceContainer.h
index 721fefccdb6cc..55014a117ba8d 100644
--- a/libcxx/test/support/MinSequenceContainer.h
+++ b/libcxx/test/support/MinSequenceContainer.h
@@ -54,7 +54,7 @@ struct MinSequenceContainer {
TEST_CONSTEXPR_CXX20 const_iterator cbegin() const { return const_iterator(data_.data()); }
TEST_CONSTEXPR_CXX20 iterator end() { return begin() + size(); }
TEST_CONSTEXPR_CXX20 const_iterator end() const { return begin() + size(); }
- TEST_CONSTEXPR_CXX20 const_iterator cend() const { return begin() + size(); }
+ TEST_CONSTEXPR_CXX20 const_iterator cend() const { return end(); }
TEST_CONSTEXPR_CXX20 size_type size() const { return static_cast<size_type>(data_.size()); }
TEST_CONSTEXPR_CXX20 bool empty() const { return data_.empty(); }
More information about the libcxx-commits
mailing list