[libcxx-commits] [libcxx] [libcxx] Add missing member `cend()` to `MinSequenceContainer` (PR #175114)
via libcxx-commits
libcxx-commits at lists.llvm.org
Thu Jan 8 19:37:58 PST 2026
llvmbot wrote:
<!--LLVM PR SUMMARY COMMENT-->
@llvm/pr-subscribers-libcxx
Author: Vojtěch Michal (vmichal)
<details>
<summary>Changes</summary>
The `MinSequenceContainer` (used in tests for `<flat_map>` and `<flat_set>`) currently provides `begin()`, `end()`, `cbegin()` but no `cend()`.
[[container.reqmts]](https://eel.is/c++draft/container.requirements#container.reqmts-33) lists member function `cend` as one of container requirements, together with `begin()` and others.
---
Full diff: https://github.com/llvm/llvm-project/pull/175114.diff
1 Files Affected:
- (modified) libcxx/test/support/MinSequenceContainer.h (+1)
``````````diff
diff --git a/libcxx/test/support/MinSequenceContainer.h b/libcxx/test/support/MinSequenceContainer.h
index f9e67cd726eb7..721fefccdb6cc 100644
--- a/libcxx/test/support/MinSequenceContainer.h
+++ b/libcxx/test/support/MinSequenceContainer.h
@@ -54,6 +54,7 @@ struct MinSequenceContainer {
TEST_CONSTEXPR_CXX20 const_iterator cbegin() const { return const_iterator(data_.data()); }
TEST_CONSTEXPR_CXX20 iterator end() { return begin() + size(); }
TEST_CONSTEXPR_CXX20 const_iterator end() const { return begin() + size(); }
+ TEST_CONSTEXPR_CXX20 const_iterator cend() const { return begin() + size(); }
TEST_CONSTEXPR_CXX20 size_type size() const { return static_cast<size_type>(data_.size()); }
TEST_CONSTEXPR_CXX20 bool empty() const { return data_.empty(); }
``````````
</details>
https://github.com/llvm/llvm-project/pull/175114
More information about the libcxx-commits
mailing list