[libcxx-commits] [libcxx] [libc++] Correct `optional<T&>` implementation (PR #174537)

[A. Jiang via libcxx-commits]

================
@@ -0,0 +1,26 @@
+//===----------------------------------------------------------------------===//
----------------
frederick-vs-ja wrote:

I don't think we should have new `.compile.fail.cpp`.
https://github.com/llvm/llvm-project/blob/75ec177483294000b361690bb4f0ab4fa7e9731a/libcxx/TODO.TXT#L17

If a case is SFINAE-friendly, I think it's better to move it to a `(.compile).pass.cpp`. If a ill-formed case is not SFINAE-friendly, or function deletion or overload ambiguity is expected, we should move the case to some `.verify.cpp`.

https://github.com/llvm/llvm-project/pull/174537