[libcxx-commits] [libcxx] [libc++] Refactor variant benchmarks (PR #174743)
Louis Dionne via libcxx-commits
libcxx-commits at lists.llvm.org
Wed Jan 7 07:46:27 PST 2026
================
@@ -50,6 +42,14 @@ static void BM_Visit(benchmark::State& state) {
}
}
-} // namespace VariantBenchmarks
-
-#endif // BENCHMARK_VARIANT_BENCHMARKS_H
+BENCHMARK(BM_Visit<1, 1>);
----------------
ldionne wrote:
We should give these benchmarks a proper name that includes `variant`. Something like `std::variant<8-alts>::visit() (K variants)`. So:
```
std::variant<8-alts>::visit() (1 variants)
std::variant<100-alts>::visit() (1 variants)
std::variant<1-alts>::visit() (2 variants)
std::variant<8-alts>::visit() (2 variants)
std::variant<50-alts>::visit() (2 variants)
std::variant<1-alts>::visit() (3 variants)
std::variant<8-alts>::visit() (3 variants)
std::variant<20-alts>::visit() (3 variants)
```
https://github.com/llvm/llvm-project/pull/174743
More information about the libcxx-commits
mailing list