[libcxx-commits] [libcxx] [libc++] P3016R6: Resolve inconsistencies in begin/end for `valarray` and braced initializer lists (PR #173637)

[Nikolas Klauser via libcxx-commits]

================
@@ -89,7 +89,9 @@ class reverse_iterator
 #ifndef _LIBCPP_ABI_NO_REVERSE_ITERATOR_SECOND_MEMBER
   _LIBCPP_HIDE_FROM_ABI _LIBCPP_CONSTEXPR_SINCE_CXX17 reverse_iterator() : __t_(), current() {}
 
-  _LIBCPP_HIDE_FROM_ABI _LIBCPP_CONSTEXPR_SINCE_CXX17 explicit reverse_iterator(_Iter __x) : __t_(__x), current(__x) {}
+  _LIBCPP_HIDE_FROM_ABI _LIBCPP_CONSTEXPR_SINCE_CXX17 explicit reverse_iterator(_Iter __x)
+      _NOEXCEPT_(is_nothrow_constructible<_Iter, _Iter&>::value)
----------------
philnik777 wrote:

Yes, please do that. This patch is quite large. More generally, I'd rather avoid these kinds of drive-by changes which are observable.

https://github.com/llvm/llvm-project/pull/173637