[libcxx-commits] [libcxx] [libc++] Fix missing 'get_new_handler()' for Windows builds (PR #150182)

[Nikolas Klauser via libcxx-commits]

philnik777 wrote:

> > If we do this it definitely requires a release note. That should include what implications this change has w.r.t. STL compatibility.
> 
> @philnik777 care to elaborate more on this? which part of these changes might have implications in regards to compatibility?

How did this interact with the MSVC STL until now? How does the behaviour change? Why did we not make it compatible with MSVC? All the questions a potential ABI break implies.

Looking at this all again, maybe the most important question is "Is this even conforming?".
Which `::operator new` do we actually use on Windows and does that use our implementation of `{s,g}et_new_handler`? Looking at the code the answer seems to be "not ours", which would make us non-conforming with this patch. Do we have a test to ensure that the new handler is called when trying to allocate too much memory?

https://github.com/llvm/llvm-project/pull/150182