[libcxx-commits] [libcxx] [libc++] Resolve LWG4370 (PR #174062)

[Nikolas Klauser via libcxx-commits]

================
@@ -0,0 +1,40 @@
+//===----------------------------------------------------------------------===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
+//
+//===----------------------------------------------------------------------===//
+
+// REQUIRES: std-at-least-c++17
+// <optional>
+
+// Verify that comparison operators of `optional` accept underlying return types convertible both from and to `bool`
+// as required by LWG4370.
+
+#include <optional>
+
+struct Bool {
+  Bool(bool) {};
+  operator bool() const { return true; };
+};
+
+struct S {
+  Bool operator==(S) const { return true; }
+  Bool operator!=(S) const { return true; }
+  Bool operator<=(S) const { return true; }
+  Bool operator<(S) const { return true; }
+  Bool operator>(S) const { return true; }
+  Bool operator>=(S) const { return true; }
+};
+
+void test() {
+  std::optional<S> s{S{}};
+
+  (void)(s == S{});
+  (void)(s != S{});
+  (void)(s < S{});
+  (void)(s > S{});
+  (void)(s <= S{});
+  (void)(s >= S{});
----------------
philnik777 wrote:

We should test that we actually do the right thing here, and not just that we compile.

https://github.com/llvm/llvm-project/pull/174062