[libcxx-commits] [libcxx] [libc++][chrono] P2592R3: Hashing for chrono (PR #165132)

Hristo Hristov via libcxx-commits libcxx-commits at lists.llvm.org
Fri Jan 2 07:01:17 PST 2026


================
@@ -0,0 +1,73 @@
+//===----------------------------------------------------------------------===//
----------------
H-G-Hristov wrote:

> I forgot the `noexcept`-ness of some `hash::operator()`s before. It should be tested here.

@rsaddatimov Can you please address this comment. Adding "noexcept-ness" tests is essential for completing this PR. 
It would be good if you also apply `[[nodiscard]]` + tests but that's not critical. I already started annotating `chrono`: https://github.com/llvm/llvm-project/pull/174121 https://github.com/llvm/llvm-project/pull/174120

https://github.com/llvm/llvm-project/pull/165132


More information about the libcxx-commits mailing list