[libcxx-commits] [libcxx] [libc++] Fix random_shuffle in __cxx03/__algorithm/shuffle.h (PR #155915)

[Nikolas Klauser via libcxx-commits]

philnik777 wrote:

> After some digging, this is fixing what seems to be an unintentional change in https://github.com/llvm/llvm-project/pull/134045/changes#r2806204202.
> 
> @philnik777 I'd like to understand how that change slipped through and whether other similar "bugs" might have been introduced.

I can't tell you how it slipped through, but I went through the lines that weren't pure deletions and I did find another case where I got things wrong in the patch (specifically https://github.com/llvm/llvm-project/pull/134045/changes/BASE..b828d663db38e37dc94633fb14cc02ae21d7ae9a#diff-94da17022286714ec0d0d3e261e0de591a6d86d3f30a5aeb5fff2f14478ebaa1L702). I may have done some manual changes in that patch, but I honestly can't remember.

https://github.com/llvm/llvm-project/pull/155915