[libcxx-commits] [libcxx] [libc++] Fix random_shuffle in __cxx03/__algorithm/shuffle.h (PR #155915)

[Louis Dionne via libcxx-commits]

https://github.com/ldionne requested changes to this pull request.

There's a few things that are wrong with this PR. We don't make changes to the C++03 frozen headers (under `__cxx03`) except for cherry-picking bug fixes that we applied to the non-frozen headers.

Is this a cherry-pick of another change? If so, the PR description should mention which change and there should probably be test changes along with the PR.

If not, the proper path would then be to fix the non-frozen headers, add a regression test, and then cherry-pick it back to the non frozen headers.

As it stands, this PR appears to be making an untested change to a set of headers that appears to be frozen, without fixing the non-frozen headers as well. Please let me know if I've misunderstood something.

https://github.com/llvm/llvm-project/pull/155915