[libcxx-commits] [libcxx] [libc++] Run all the microbenchmarks in run-benchmarks (PR #181374)

[via libcxx-commits]

llvmbot wrote:


<!--LLVM PR SUMMARY COMMENT-->

@llvm/pr-subscribers-libcxx

Author: Louis Dionne (ldionne)

<details>
<summary>Changes</summary>

Running all the benchmarks does not significantly increase the total time, and it ensures that what we upload to LNT corresponds exactly to what's in the test suite.

---
Full diff: https://github.com/llvm/llvm-project/pull/181374.diff


1 Files Affected:

- (modified) libcxx/utils/ci/lnt/run-benchmarks (+1-4) 


``````````diff
diff --git a/libcxx/utils/ci/lnt/run-benchmarks b/libcxx/utils/ci/lnt/run-benchmarks
index e2d1980f3f92a..8f9ff72ef3166 100755
--- a/libcxx/utils/ci/lnt/run-benchmarks
+++ b/libcxx/utils/ci/lnt/run-benchmarks
@@ -156,8 +156,6 @@ def main(argv):
             with open(build_dir / 'benchmarks.lnt', 'a') as f:
                 run([args.git_repo / 'libcxx/utils/consolidate-benchmarks', build_dir / 'spec'], stdout=f)
 
-        # TODO: For now, we run only a subset of the benchmarks because running the whole test suite is too slow.
-        #       Run the whole test suite once https://github.com/llvm/llvm-project/issues/173032 is resolved.
         if do_micro:
             logging.info(f'Running microbenchmarks from {args.test_suite_commit} against libc++ {args.benchmark_commit}')
             run([args.git_repo / 'libcxx/utils/test-at-commit',
@@ -170,8 +168,7 @@ def main(argv):
                             '--param', f'compiler={args.compiler}',
                             '--param', 'optimization=speed',
                             '--param', 'std=c++26',
-                            build_dir / 'micro/libcxx/test',
-                            '--filter', 'benchmarks/(algorithms|containers|iterators|locale|memory|streams|numeric|utility)'],
+                            build_dir / 'micro/libcxx/test/benchmarks'],
                             enforce_success=False)
             with open(build_dir / 'benchmarks.lnt', 'a') as f:
                 run([args.git_repo / 'libcxx/utils/consolidate-benchmarks', build_dir / 'micro'], stdout=f)

``````````

</details>


https://github.com/llvm/llvm-project/pull/181374