[libcxx-commits] [libcxx] 30f4b9c - [libc++] Use ValueError instead of non-existent ArgumentError (#179526)

via libcxx-commits libcxx-commits at lists.llvm.org
Tue Feb 10 09:47:12 PST 2026


Author: Louis Dionne
Date: 2026-02-10T12:47:06-05:00
New Revision: 30f4b9c8bef50ffabc434e30c492e039eebb7c81

URL: https://github.com/llvm/llvm-project/commit/30f4b9c8bef50ffabc434e30c492e039eebb7c81
DIFF: https://github.com/llvm/llvm-project/commit/30f4b9c8bef50ffabc434e30c492e039eebb7c81.diff

LOG: [libc++] Use ValueError instead of non-existent ArgumentError (#179526)

ArgumentError does not exist. argparse.ArgumentError does exist, but
that is not what we want to use. I presume this was never caught because
we never execute that line.

Added: 
    

Modified: 
    libcxx/test/libcxx-03/transitive_includes/to_csv.py
    libcxx/test/libcxx/transitive_includes/to_csv.py

Removed: 
    


################################################################################
diff  --git a/libcxx/test/libcxx-03/transitive_includes/to_csv.py b/libcxx/test/libcxx-03/transitive_includes/to_csv.py
index 69d94deedf6f5..3035ff6cfe5c8 100755
--- a/libcxx/test/libcxx-03/transitive_includes/to_csv.py
+++ b/libcxx/test/libcxx-03/transitive_includes/to_csv.py
@@ -28,7 +28,7 @@ def parse_line(line: str) -> Tuple[int, str]:
     """
     match = re.match(r"(\.+) (.+)", line)
     if not match:
-        raise ArgumentError(f"Line {line} contains invalid data.")
+        raise ValueError(f"Line {line} contains invalid data.")
 
     # The number of periods in front of the header name is the nesting level of
     # that header.

diff  --git a/libcxx/test/libcxx/transitive_includes/to_csv.py b/libcxx/test/libcxx/transitive_includes/to_csv.py
index 69d94deedf6f5..3035ff6cfe5c8 100755
--- a/libcxx/test/libcxx/transitive_includes/to_csv.py
+++ b/libcxx/test/libcxx/transitive_includes/to_csv.py
@@ -28,7 +28,7 @@ def parse_line(line: str) -> Tuple[int, str]:
     """
     match = re.match(r"(\.+) (.+)", line)
     if not match:
-        raise ArgumentError(f"Line {line} contains invalid data.")
+        raise ValueError(f"Line {line} contains invalid data.")
 
     # The number of periods in front of the header name is the nesting level of
     # that header.


        


More information about the libcxx-commits mailing list