[libcxx-commits] [libcxx] hxie/semaphore debug3 (PR #180360)
via libcxx-commits
libcxx-commits at lists.llvm.org
Sat Feb 7 11:46:09 PST 2026
https://github.com/huixie90 updated https://github.com/llvm/llvm-project/pull/180360
>From 79cc6e2cc0b253b0a34a3b5ad302341fa943170b Mon Sep 17 00:00:00 2001
From: Hui Xie <hui.xie1990 at gmail.com>
Date: Sat, 7 Feb 2026 16:19:16 +0000
Subject: [PATCH 1/6] [libc++] debug semaaphore
---
.../thread.semaphore/timed.debug.pass.cpp | 84 +++++++++++++++++++
1 file changed, 84 insertions(+)
create mode 100644 libcxx/test/std/thread/thread.semaphore/timed.debug.pass.cpp
diff --git a/libcxx/test/std/thread/thread.semaphore/timed.debug.pass.cpp b/libcxx/test/std/thread/thread.semaphore/timed.debug.pass.cpp
new file mode 100644
index 0000000000000..d7833194927e4
--- /dev/null
+++ b/libcxx/test/std/thread/thread.semaphore/timed.debug.pass.cpp
@@ -0,0 +1,84 @@
+//===----------------------------------------------------------------------===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
+//
+//===----------------------------------------------------------------------===//
+//
+// UNSUPPORTED: no-threads
+// UNSUPPORTED: c++03, c++11, c++14, c++17
+
+// <semaphore>
+
+#include <semaphore>
+#include <thread>
+#include <chrono>
+#include <cassert>
+#include <iostream>
+#include <iomanip>
+
+
+#include "make_test_thread.h"
+#include "test_macros.h"
+
+int main(int, char**)
+{
+ auto const start = std::chrono::steady_clock::now();
+ auto log = [start] ()-> auto& {
+ using namespace std::chrono;
+
+ auto elapsed = steady_clock::now() - start;
+
+ auto hours = duration_cast<std::chrono::hours>(elapsed);
+ elapsed -= hours;
+
+ auto minutes = duration_cast<std::chrono::minutes>(elapsed);
+ elapsed -= minutes;
+
+ auto seconds = duration_cast<std::chrono::seconds>(elapsed);
+ elapsed -= seconds;
+
+ auto milliseconds = duration_cast<std::chrono::milliseconds>(elapsed);
+
+ std::cerr << "["
+ << std::setw(2) << std::setfill('0') << hours.count() << ":"
+ << std::setw(2) << std::setfill('0') << minutes.count() << ":"
+ << std::setw(2) << std::setfill('0') << seconds.count() << "."
+ << std::setw(3) << std::setfill('0') << milliseconds.count()
+ << "] ";
+
+ return std::cerr;
+ };
+
+ std::counting_semaphore<> s(0);
+
+ log() << "try_acquire_until: start + " << std::chrono::milliseconds(250) << "\n";
+ assert(!s.try_acquire_until(start + std::chrono::milliseconds(250)));
+ log() << "done: try_acquire_until: start + " << std::chrono::milliseconds(250) << "\n";
+
+ log() << "try_acquire_for: " << std::chrono::milliseconds(250) << "\n";
+ assert(!s.try_acquire_for(std::chrono::milliseconds(250)));
+ log() << "done: try_acquire_for: " << std::chrono::milliseconds(250) << "\n";
+
+ std::thread t = support::make_test_thread([&](){
+ std::this_thread::sleep_for(std::chrono::milliseconds(250));
+ s.release();
+ std::this_thread::sleep_for(std::chrono::milliseconds(250));
+ s.release();
+ });
+
+ log() << "try_acquire_until: start + " << std::chrono::seconds(2) << "\n";
+ assert(s.try_acquire_until(start + std::chrono::seconds(2)));
+ log() << "done: try_acquire_until: start + " << std::chrono::seconds(2) << "\n";
+
+ log() << "try_acquire_for: " << std::chrono::seconds(2) << "\n";
+ assert(s.try_acquire_for(std::chrono::seconds(2)));
+ log() << "done: try_acquire_for: " << std::chrono::seconds(2) << "\n";
+ t.join();
+
+ auto const end = std::chrono::steady_clock::now();
+ assert(end - start < std::chrono::seconds(10));
+
+ return 1;
+}
>From 15caf8d017581b2ac398c6e89c3b9bd9cb81180d Mon Sep 17 00:00:00 2001
From: Hui Xie <hui.xie1990 at gmail.com>
Date: Sat, 7 Feb 2026 16:23:48 +0000
Subject: [PATCH 2/6] code to debug
---
.../thread.semaphore/timed.debug.pass.cpp | 34 ++++++++++++-------
1 file changed, 21 insertions(+), 13 deletions(-)
diff --git a/libcxx/test/std/thread/thread.semaphore/timed.debug.pass.cpp b/libcxx/test/std/thread/thread.semaphore/timed.debug.pass.cpp
index d7833194927e4..904da25a49940 100644
--- a/libcxx/test/std/thread/thread.semaphore/timed.debug.pass.cpp
+++ b/libcxx/test/std/thread/thread.semaphore/timed.debug.pass.cpp
@@ -22,13 +22,11 @@
#include "make_test_thread.h"
#include "test_macros.h"
-int main(int, char**)
-{
- auto const start = std::chrono::steady_clock::now();
- auto log = [start] ()-> auto& {
+void test(auto log_start){
+ auto log = [log_start] ()-> auto& {
using namespace std::chrono;
- auto elapsed = steady_clock::now() - start;
+ auto elapsed = steady_clock::now() - log_start;
auto hours = duration_cast<std::chrono::hours>(elapsed);
elapsed -= hours;
@@ -51,15 +49,16 @@ int main(int, char**)
return std::cerr;
};
+ auto const start = std::chrono::steady_clock::now();
std::counting_semaphore<> s(0);
- log() << "try_acquire_until: start + " << std::chrono::milliseconds(250) << "\n";
+ log() << "start: try_acquire_until: start + " << std::chrono::milliseconds(250) << "\n";
assert(!s.try_acquire_until(start + std::chrono::milliseconds(250)));
- log() << "done: try_acquire_until: start + " << std::chrono::milliseconds(250) << "\n";
+ log() << "done: try_acquire_until: start + " << std::chrono::milliseconds(250) << "\n";
- log() << "try_acquire_for: " << std::chrono::milliseconds(250) << "\n";
+ log() << "start: try_acquire_for: " << std::chrono::milliseconds(250) << "\n";
assert(!s.try_acquire_for(std::chrono::milliseconds(250)));
- log() << "done: try_acquire_for: " << std::chrono::milliseconds(250) << "\n";
+ log() << "done: try_acquire_for: " << std::chrono::milliseconds(250) << "\n";
std::thread t = support::make_test_thread([&](){
std::this_thread::sleep_for(std::chrono::milliseconds(250));
@@ -68,17 +67,26 @@ int main(int, char**)
s.release();
});
- log() << "try_acquire_until: start + " << std::chrono::seconds(2) << "\n";
+ log() << "start: try_acquire_until: start + " << std::chrono::seconds(2) << "\n";
assert(s.try_acquire_until(start + std::chrono::seconds(2)));
- log() << "done: try_acquire_until: start + " << std::chrono::seconds(2) << "\n";
+ log() << "done: try_acquire_until: start + " << std::chrono::seconds(2) << "\n";
- log() << "try_acquire_for: " << std::chrono::seconds(2) << "\n";
+ log() << "start: try_acquire_for: " << std::chrono::seconds(2) << "\n";
assert(s.try_acquire_for(std::chrono::seconds(2)));
- log() << "done: try_acquire_for: " << std::chrono::seconds(2) << "\n";
+ log() << "done: try_acquire_for: " << std::chrono::seconds(2) << "\n";
t.join();
auto const end = std::chrono::steady_clock::now();
assert(end - start < std::chrono::seconds(10));
+}
+
+int main(int, char**)
+{
+ auto const log_start = std::chrono::steady_clock::now();
+ for (auto i = 0; i < 10; ++i) {
+ std::cerr << "=== Iteration " << i << " ===\n";
+ test(log_start);
+ }
return 1;
}
>From 09616457c9c0868806e5a3735ca9706f963e6066 Mon Sep 17 00:00:00 2001
From: Hui Xie <hui.xie1990 at gmail.com>
Date: Sat, 7 Feb 2026 16:44:11 +0000
Subject: [PATCH 3/6] stage3
---
libcxx/test/std/thread/thread.semaphore/timed.debug.pass.cpp | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/libcxx/test/std/thread/thread.semaphore/timed.debug.pass.cpp b/libcxx/test/std/thread/thread.semaphore/timed.debug.pass.cpp
index 904da25a49940..d032145f9824d 100644
--- a/libcxx/test/std/thread/thread.semaphore/timed.debug.pass.cpp
+++ b/libcxx/test/std/thread/thread.semaphore/timed.debug.pass.cpp
@@ -88,5 +88,10 @@ int main(int, char**)
test(log_start);
}
+#if defined(_WIN32)
return 1;
+#else
+ return 0;
+#endif
+
}
>From 3cdaf211c7cf70f4a6f7924be8d015de4355e9cb Mon Sep 17 00:00:00 2001
From: Hui Xie <hui.xie1990 at gmail.com>
Date: Sat, 7 Feb 2026 17:56:32 +0000
Subject: [PATCH 4/6] endl
---
.../thread.semaphore/timed.debug.pass.cpp | 46 ++++++++-----------
1 file changed, 20 insertions(+), 26 deletions(-)
diff --git a/libcxx/test/std/thread/thread.semaphore/timed.debug.pass.cpp b/libcxx/test/std/thread/thread.semaphore/timed.debug.pass.cpp
index d032145f9824d..4ad84b2bbb00a 100644
--- a/libcxx/test/std/thread/thread.semaphore/timed.debug.pass.cpp
+++ b/libcxx/test/std/thread/thread.semaphore/timed.debug.pass.cpp
@@ -1,13 +1,13 @@
//===----------------------------------------------------------------------===//
//
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
-// See https://llvm.org/LICENSE.txt for license information.
+// See https://llvm.org/LICESE.txt for license information.
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
//
//===----------------------------------------------------------------------===//
//
-// UNSUPPORTED: no-threads
-// UNSUPPORTED: c++03, c++11, c++14, c++17
+// USUPPORTED: no-threads
+// USUPPORTED: c++03, c++11, c++14, c++17
// <semaphore>
@@ -18,12 +18,11 @@
#include <iostream>
#include <iomanip>
-
#include "make_test_thread.h"
#include "test_macros.h"
-void test(auto log_start){
- auto log = [log_start] ()-> auto& {
+void test(auto log_start) {
+ auto log = [log_start]() -> auto& {
using namespace std::chrono;
auto elapsed = steady_clock::now() - log_start;
@@ -39,12 +38,9 @@ void test(auto log_start){
auto milliseconds = duration_cast<std::chrono::milliseconds>(elapsed);
- std::cerr << "["
- << std::setw(2) << std::setfill('0') << hours.count() << ":"
- << std::setw(2) << std::setfill('0') << minutes.count() << ":"
- << std::setw(2) << std::setfill('0') << seconds.count() << "."
- << std::setw(3) << std::setfill('0') << milliseconds.count()
- << "] ";
+ std::cerr << "[" << std::setw(2) << std::setfill('0') << hours.count() << ":" << std::setw(2) << std::setfill('0')
+ << minutes.count() << ":" << std::setw(2) << std::setfill('0') << seconds.count() << "." << std::setw(3)
+ << std::setfill('0') << milliseconds.count() << "] ";
return std::cerr;
};
@@ -52,46 +48,44 @@ void test(auto log_start){
auto const start = std::chrono::steady_clock::now();
std::counting_semaphore<> s(0);
- log() << "start: try_acquire_until: start + " << std::chrono::milliseconds(250) << "\n";
+ log() << "start: try_acquire_until: start + " << std::chrono::milliseconds(250) << std::endl;
assert(!s.try_acquire_until(start + std::chrono::milliseconds(250)));
- log() << "done: try_acquire_until: start + " << std::chrono::milliseconds(250) << "\n";
+ log() << "done: try_acquire_until: start + " << std::chrono::milliseconds(250) << std::endl;
- log() << "start: try_acquire_for: " << std::chrono::milliseconds(250) << "\n";
+ log() << "start: try_acquire_for: " << std::chrono::milliseconds(250) << std::endl;
assert(!s.try_acquire_for(std::chrono::milliseconds(250)));
- log() << "done: try_acquire_for: " << std::chrono::milliseconds(250) << "\n";
+ log() << "done: try_acquire_for: " << std::chrono::milliseconds(250) << std::endl;
- std::thread t = support::make_test_thread([&](){
+ std::thread t = support::make_test_thread([&]() {
std::this_thread::sleep_for(std::chrono::milliseconds(250));
s.release();
std::this_thread::sleep_for(std::chrono::milliseconds(250));
s.release();
});
- log() << "start: try_acquire_until: start + " << std::chrono::seconds(2) << "\n";
+ log() << "start: try_acquire_until: start + " << std::chrono::seconds(2) << std::endl;
assert(s.try_acquire_until(start + std::chrono::seconds(2)));
- log() << "done: try_acquire_until: start + " << std::chrono::seconds(2) << "\n";
+ log() << "done: try_acquire_until: start + " << std::chrono::seconds(2) << std::endl;
- log() << "start: try_acquire_for: " << std::chrono::seconds(2) << "\n";
+ log() << "start: try_acquire_for: " << std::chrono::seconds(2) << std::endl;
assert(s.try_acquire_for(std::chrono::seconds(2)));
- log() << "done: try_acquire_for: " << std::chrono::seconds(2) << "\n";
+ log() << "done: try_acquire_for: " << std::chrono::seconds(2) << std::endl;
t.join();
auto const end = std::chrono::steady_clock::now();
assert(end - start < std::chrono::seconds(10));
}
-int main(int, char**)
-{
+int main(int, char**) {
auto const log_start = std::chrono::steady_clock::now();
for (auto i = 0; i < 10; ++i) {
- std::cerr << "=== Iteration " << i << " ===\n";
+ std::cerr << "=== Iteration " << i << " ===" << std::endl;
test(log_start);
}
-#if defined(_WIN32)
+#if defined(_WI32)
return 1;
#else
return 0;
#endif
-
}
>From 26afc25c1cb7467104c54816ee6bf5b22481c240 Mon Sep 17 00:00:00 2001
From: Hui Xie <hui.xie1990 at gmail.com>
Date: Sat, 7 Feb 2026 19:43:23 +0000
Subject: [PATCH 5/6] debug
---
.../test/std/thread/thread.semaphore/timed.debug.pass.cpp | 8 ++------
1 file changed, 2 insertions(+), 6 deletions(-)
diff --git a/libcxx/test/std/thread/thread.semaphore/timed.debug.pass.cpp b/libcxx/test/std/thread/thread.semaphore/timed.debug.pass.cpp
index 4ad84b2bbb00a..9f7be32b5100c 100644
--- a/libcxx/test/std/thread/thread.semaphore/timed.debug.pass.cpp
+++ b/libcxx/test/std/thread/thread.semaphore/timed.debug.pass.cpp
@@ -6,8 +6,8 @@
//
//===----------------------------------------------------------------------===//
//
-// USUPPORTED: no-threads
-// USUPPORTED: c++03, c++11, c++14, c++17
+// UNSUPPORTED: no-threads
+// UNSUPPORTED: c++03, c++11, c++14, c++17
// <semaphore>
@@ -83,9 +83,5 @@ int main(int, char**) {
test(log_start);
}
-#if defined(_WI32)
- return 1;
-#else
return 0;
-#endif
}
>From 947b6d6cba07ff7556c3228970d4a3aedca85c14 Mon Sep 17 00:00:00 2001
From: Hui Xie <hui.xie1990 at gmail.com>
Date: Sat, 7 Feb 2026 19:45:55 +0000
Subject: [PATCH 6/6] increase
---
libcxx/test/std/thread/thread.semaphore/timed.debug.pass.cpp | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/libcxx/test/std/thread/thread.semaphore/timed.debug.pass.cpp b/libcxx/test/std/thread/thread.semaphore/timed.debug.pass.cpp
index 9f7be32b5100c..a4241c9a2b2c7 100644
--- a/libcxx/test/std/thread/thread.semaphore/timed.debug.pass.cpp
+++ b/libcxx/test/std/thread/thread.semaphore/timed.debug.pass.cpp
@@ -78,7 +78,7 @@ void test(auto log_start) {
int main(int, char**) {
auto const log_start = std::chrono::steady_clock::now();
- for (auto i = 0; i < 10; ++i) {
+ for (auto i = 0; i < 20; ++i) {
std::cerr << "=== Iteration " << i << " ===" << std::endl;
test(log_start);
}
More information about the libcxx-commits
mailing list