[libcxx-commits] [libcxx] [libc++] Implement P0493R5: Atomic minimum/maximum (PR #180333)

Hristo Hristov via libcxx-commits libcxx-commits at lists.llvm.org
Sat Feb 7 10:22:40 PST 2026


H-G-Hristov wrote:

> > You can try to rebase to trigger the CI again.
> 
> As per https://llvm.org/docs/GitHub.html#rebasing-pull-requests-and-force-pushes, we should avoid unnecessary rebases.
> 
> Regarding the various style suggestions (like `typedef`, concepts, and docstrings): They may look _odd_ but maintain consistency with existing implementations and test cases. While I'm open to changing them in this patch, I think it would be clearer to address them all in a subsequent NFC patch, since these aren't pressing issues. Either way, I'll wait for the maintainers' input on this.

You need to make the CI green if possible (that means sometimes there are unrelated failures). In this case to trigger the buildkite build you need to rebase.

https://github.com/llvm/llvm-project/pull/180333


More information about the libcxx-commits mailing list