[libcxx-commits] [libcxx] [libc++] Make `__wrap_iter` comparison operators hidden friends (PR #179590)
via libcxx-commits
libcxx-commits at lists.llvm.org
Tue Feb 3 17:49:55 PST 2026
github-actions[bot] wrote:
<!--LLVM CODE FORMAT COMMENT: {clang-format}-->
:warning: C/C++ code formatter, clang-format found issues in your code. :warning:
<details>
<summary>
You can test this locally with the following command:
</summary>
``````````bash
git-clang-format --diff origin/main HEAD --extensions h -- libcxx/include/__iterator/wrap_iter.h --diff_from_common_commit
``````````
:warning:
The reproduction instructions above might return results for more than one PR
in a stack if you are using a stacked PR workflow. You can limit the results by
changing `origin/main` to the base branch/commit you want to compare against.
:warning:
</details>
<details>
<summary>
View the diff from clang-format here.
</summary>
``````````diff
diff --git a/libcxx/include/__iterator/wrap_iter.h b/libcxx/include/__iterator/wrap_iter.h
index ab5b0d2b6..234c9a4f8 100644
--- a/libcxx/include/__iterator/wrap_iter.h
+++ b/libcxx/include/__iterator/wrap_iter.h
@@ -143,8 +143,8 @@ private:
}
#if _LIBCPP_STD_VER <= 17
- _LIBCPP_HIDE_FROM_ABI friend _LIBCPP_CONSTEXPR bool
- operator!=(const __wrap_iter& __x, const __wrap_iter& __y) _NOEXCEPT {
+ _LIBCPP_HIDE_FROM_ABI friend
+ _LIBCPP_CONSTEXPR bool operator!=(const __wrap_iter& __x, const __wrap_iter& __y) _NOEXCEPT {
return !(__x == __y);
}
@@ -211,8 +211,8 @@ private:
operator-(const __wrap_iter& __x, const __wrap_iter<_Iter2>& __y) _NOEXCEPT->decltype(__x.base() - __y.base())
#else
template <class _Iter2>
- _LIBCPP_HIDE_FROM_ABI friend _LIBCPP_CONSTEXPR_SINCE_CXX14 typename __wrap_iter::difference_type
- operator-(const __wrap_iter& __x, const __wrap_iter<_Iter2>& __y) _NOEXCEPT
+ _LIBCPP_HIDE_FROM_ABI friend _LIBCPP_CONSTEXPR_SINCE_CXX14
+ typename __wrap_iter::difference_type operator-(const __wrap_iter& __x, const __wrap_iter<_Iter2>& __y) _NOEXCEPT
#endif // C++03
{
return __x.base() - __y.base();
``````````
</details>
https://github.com/llvm/llvm-project/pull/179590
More information about the libcxx-commits
mailing list