[libcxx-commits] [libcxx] [libcxx] Default BUILDKITE_PULL_REQUEST_BASE_BRANCH to main when unset (PR #179252)

[via libcxx-commits]

llvmbot wrote:


<!--LLVM PR SUMMARY COMMENT-->

@llvm/pr-subscribers-libcxx

Author: Phives (dive2tech)

<details>
<summary>Changes</summary>

The libcxx Buildkite trigger step fails when `BUILDKITE_PULL_REQUEST_BASE_BRANCH` is unset (e.g. for cross-fork PRs), because `git diff origin/...HEAD` is an invalid revision.

Default to `main` when the variable is unset so the script can determine modified files and exit cleanly with "No Buildkite jobs to trigger" when only non-libcxx paths are changed.

This fixes Buildkite CI failures for PRs from forks where the base branch env is not set.

---
Full diff: https://github.com/llvm/llvm-project/pull/179252.diff


1 Files Affected:

- (modified) libcxx/utils/ci/buildkite-pipeline-trigger.sh (+2-2) 


``````````diff
diff --git a/libcxx/utils/ci/buildkite-pipeline-trigger.sh b/libcxx/utils/ci/buildkite-pipeline-trigger.sh
index 4661cd54fad42..47128a80b4338 100755
--- a/libcxx/utils/ci/buildkite-pipeline-trigger.sh
+++ b/libcxx/utils/ci/buildkite-pipeline-trigger.sh
@@ -12,8 +12,8 @@
 # LLVM monorepo, and we make it a no-op unless the libc++ pipeline needs to be triggered.
 #
 
-# Set by buildkite
-: ${BUILDKITE_PULL_REQUEST_BASE_BRANCH:=}
+# Set by buildkite (may be unset for cross-fork PRs)
+: ${BUILDKITE_PULL_REQUEST_BASE_BRANCH:=main}
 
 # Fetch origin to have an up to date merge base for the diff.
 git fetch origin

``````````

</details>


https://github.com/llvm/llvm-project/pull/179252