[libcxx-commits] [libcxx] Properly implement std::fs::is_socket() on Windows (PR #213233)

Hristo Hristov via libcxx-commits libcxx-commits at lists.llvm.org
Sun Aug 30 21:40:49 PDT 2026


================
@@ -165,8 +171,16 @@ inline int stat_handle(HANDLE h, StatT* buf) {
     FILE_ATTRIBUTE_TAG_INFO tag;
     if (!GetFileInformationByHandleEx(h, FileAttributeTagInfo, &tag, sizeof(tag)))
       return -1;
-    if (tag.ReparseTag == IO_REPARSE_TAG_SYMLINK)
+    if (tag.ReparseTag == IO_REPARSE_TAG_SYMLINK) {
----------------
Zingam wrote:

```suggestion
    if (tag.ReparseTag == IO_REPARSE_TAG_SYMLINK)
```

AFAIK This looks like unnecessary change which also violates LLVMs style for one-liners.

https://github.com/llvm/llvm-project/pull/213233


More information about the libcxx-commits mailing list