[libcxx-commits] [libcxx] [libc++] added benchmarks for `string::append()` (PR #213990)

[Nikolas Klauser via libcxx-commits]

================
@@ -43,6 +43,25 @@ void bench(std::string name, Func func, Mod modifier = {}) {
 #endif
 }
 
+template <typename Iterator>
----------------
philnik777 wrote:

> > Something similar to what is added in this patch.
> 
> I don't understand what you mean by "something similar", please be more specific.

I don't know what you want me to tell you. "something similar to this patch" isn't exactly hard to understand by most people. "a follow-up patch similar to this one" would be another way to phrase it.

> > Any containers fulfilling [sequence.requirements] or [unord.req] and any overloads in there taking i, j.
> 
> Can you give an example of such place?

http://eel.is/c++draft/vector#lib:vector,constructor___ - but you could also just open your browser and do a tiny bit of work next time.


https://github.com/llvm/llvm-project/pull/213990