[libcxx-commits] [libcxx] [libc++] Do not define std::nothrow with VCRuntime ABI (PR #217694)

[Martin Storsjö via libcxx-commits]

mstorsjo wrote:

> However, should we treat using such "manual libc++ link flags" as a correct building way? Is this way documented as valid?

I wouldn't necessarily think such a thing requires explicit documentation. If there's conflicting symbols in various parts of a toolchain, you can have a number of cases that run successfully, and then some linking scenarios hit the issue. And the fix usually is to avoid potentially conflicting definitions of things.

If we can remove the conflicting definition while CI still passes, that sounds good to me. And if we can add a testcase that explicitly triggers the situation, that's even better - but I would be ok even without it; this kind of scenario is a familiar case for toolchain maintainers.

> Oh hey @mstorsjo ! We met at FOSDEM for our respective talks ! Great to see you here :)

Hello, good to see you here too!

https://github.com/llvm/llvm-project/pull/217694