[libcxx-commits] [libcxx] [libc++][ranges][enumerate_view] Fix sentinel converting constructor test (PR #217365)

[Hristo Hristov via libcxx-commits]

================
@@ -47,17 +108,23 @@ constexpr void test() {
   std::array array{0, 1, 2, 3, 84};
   auto view = make_enumerate_view(array.begin(), array.end());
 
-  std::same_as<EnumerateSentinel> decltype(auto) s = view.end();
-  std::same_as<Sentinel> decltype(auto) sResult    = s.base();
-  assert(base(base(sResult)) == std::to_address(base(array.end())));
-
-  // Test assignment
-  EnumerateConstSentinel cs                      = s;
-  std::same_as<Sentinel> decltype(auto) csResult = cs.base();
-  assert(base(base(csResult)) == std::to_address(base(array.end())));
+  {
+    // Assigning a non-const sentinel to a const-sentinel-typed variable invokes
+    // the converting constructor.
+    std::same_as<EnumerateSentinel> decltype(auto) s = view.end();
----------------
Zingam wrote:

```suggestion
    std::same_as<EnumerateSentinel> decltype(auto) st = view.end();
```
Let's use `st` for sentinel variables.

https://github.com/llvm/llvm-project/pull/217365