[libcxx-commits] [libcxx] [libc++] P0718R2: Implementation of std::atomic<shared_ptr<T>> and std::atomic<weak_ptr<T>> (PR #194215)

[Hristo Hristov via libcxx-commits]

https://github.com/Zingam commented:

> @H-G-Hristov, @huixie90, @dalg24, almost all the CIs passed, 3 skipped, I think it is because Github erroneously marked "macos (apple-system-hardenedm, 26.5)" as failed. Can you review please, and do not forget about this:
> 
> > I've marked two spots with `TODO` that I'd like extra attention on: strict aliasing in `__dwcas_address()` and a potential ABA issue in `__load_dwcas`.
> 
> from [#194215 (comment)](https://github.com/llvm/llvm-project/pull/194215#issuecomment-4583322201).

I would rather comment only on general libc++ practices and leave the implementation details to the expert.

Let's add a Release Note entry to to `docs/ReleaseNotes/24.rst` with a note that this impelents just the `atomic_shared` pointer. When we merge this: https://github.com/llvm/llvm-project/pull/194544 I'll update it to state we've completed the paper. I expect that we merge this patch first and then the other one, which was once merge and then reverted on request: https://github.com/llvm/llvm-project/pull/194544


https://github.com/llvm/llvm-project/pull/194215