[libcxx-commits] [libcxx] [libc++] Implement LWG4072: std::optional comparisons: constrain harder (PR #209968)

[Hristo Hristov via libcxx-commits]

Zingam wrote:

> > Have you tested the changes individually to see the effects? While on the surface the changes might look OK, my concerns are that this PR is not quite ready yet but I am not quite sure what needs to be done next.
> 
> I tested the affected files on a local build though llvm-lit, which all passed. I recall it failed on libunwind which this PR doesn't touch. Could a rerun on the checks please be done?

1. Have you checked if the new tests pass without the change to the constraint? If they still pass, IMO these tests don't verify the change sufficiently.
2. Have you verified the change to the constraint? Does it do what it you expected it to do? Is there an improvment/any change in the compiler diagnostics?


https://github.com/llvm/llvm-project/pull/209968