[libcxx-commits] [libcxx] [libc++] Test existence of generated headers in the modulemap (PR #209312)

[Nikolas Klauser via libcxx-commits]

================
@@ -1694,16 +1694,21 @@ set(files
 configure_file("__config_site.in" "${LIBCXX_GENERATED_INCLUDE_TARGET_DIR}/__config_site" @ONLY)
 configure_file("${LIBCXX_ASSERTION_HANDLER_FILE}" "${LIBCXX_GENERATED_INCLUDE_DIR}/__assertion_handler" COPYONLY)
 
-# We generate the modulemap file so that we can include __config_site in it. For now, we don't know how to
-# make __config_site modular when per-target runtime directories are used.
-if (NOT LLVM_ENABLE_PER_TARGET_RUNTIME_DIR)
+# We generate the modulemap file so that we can include __config_site in it. When using a target-specific include
+# directory, give it its own modulemap.
+if (LLVM_ENABLE_PER_TARGET_RUNTIME_DIR)
----------------
philnik777 wrote:

Side note: it would be really nice if we could always use per-target runtime dirs. Is there a reason we can't do that?

https://github.com/llvm/llvm-project/pull/209312