[libcxx-commits] [libcxx] [libc++] Trim down associative container benchmark sizes (PR #212252)
Nikolas Klauser via libcxx-commits
libcxx-commits at lists.llvm.org
Tue Aug 4 01:28:20 PDT 2026
https://github.com/philnik777 approved this pull request.
> @philnik777 When we use `Arg(0)`, it's not clear to me that we're measuring anything meaningful though. Many of these benchmarks contain `PauseTiming` and `ResumeTiming`, and that would trump the measurement of a cheap `n = 0` operation. Don't you think?
Maybe. I mostly want to keep them to make sure they stay cheap though. We can test that more thoroughly, but I think this is an uncontroversial change as-is, so let's land this and I can investigate that separately if you want.
Also worth noting, while there are quite a few which use `Pause/ResumeTiming`, there are also some which don't, so there I don't think this is much of a concern.
https://github.com/llvm/llvm-project/pull/212252
More information about the libcxx-commits
mailing list