[libcxx-commits] [libcxx] [libc++] Avoid more <format> code in <vector> (PR #185596)

[Louis Dionne via libcxx-commits]

================

----------------
ldionne wrote:

I think we need to figure out whether the `scope_guard` is required here, otherwise we're making the code look like it's important, when in reality we just blindly tried to preserve the exact semantics of the existing code through this refactor.

I'd try doing the naive thing (no scope guard) and see if tests complain. Then I'd also look at the existing exception tests for `format` and see what guarantees they are asserting, and try to reason from there.

https://github.com/llvm/llvm-project/pull/185596