[libcxx-commits] [libcxx] [llvm] [libcxx][Github] Add generic-llvm-libc config to CI (PR #193822)

[via libcxx-commits]

llvmbot wrote:


<!--LLVM PR SUMMARY COMMENT-->

@llvm/pr-subscribers-libcxx

Author: Aiden Grossman (boomanaiden154)

<details>
<summary>Changes</summary>

Add the generic-llvm-libc config for CI so that we can ensure we do not regress the config and easily test changes as we do more work.

Only run libcxx/libxxabi tests for now as libunwind fails to build due to a missing dl_iterate_phdr implementation. It technically passes when we enable the stub implementation, but we should have a reasonable implementation before actually enabling.

---
Full diff: https://github.com/llvm/llvm-project/pull/193822.diff


2 Files Affected:

- (modified) .github/workflows/libcxx-build-and-test.yaml (+1) 
- (modified) libcxx/utils/ci/run-buildbot (+13-1) 


``````````diff
diff --git a/.github/workflows/libcxx-build-and-test.yaml b/.github/workflows/libcxx-build-and-test.yaml
index 83f8f89ac5fe2..c5421addefa30 100644
--- a/.github/workflows/libcxx-build-and-test.yaml
+++ b/.github/workflows/libcxx-build-and-test.yaml
@@ -144,6 +144,7 @@ jobs:
           'generic-hardening-mode-extensive-observe-semantic',
           'generic-hardening-mode-fast',
           'generic-hardening-mode-fast-with-abi-breaks',
+          'generic-llvm-libc',
           'generic-merged',
           'generic-modules-cxx17-lsv',
           'generic-no-exceptions',
diff --git a/libcxx/utils/ci/run-buildbot b/libcxx/utils/ci/run-buildbot
index cbb0846dfc7d1..44507f05011fa 100755
--- a/libcxx/utils/ci/run-buildbot
+++ b/libcxx/utils/ci/run-buildbot
@@ -466,7 +466,19 @@ generic-llvm-libc)
     # Ensure we have the builtins archive built as we pass it in explicitly in
     # the test config.
     ninja -vC "${BUILD_DIR}" libclang_rt.builtins-x86_64.a
-    check-runtimes
+
+    # Manually run only libcxx/libcxxabi tests as we currently cannot build
+    # libunwind due to a missing dl_iterate_phdr implementation.
+    # TODO(boomanaiden154): Remove this once we can build libunwind and pass
+    # the tests.
+    step "Building libc++ test dependencies"
+    ninja -vC "${BUILD_DIR}" cxx-test-depends
+
+    step "Running the libc++ tests"
+    ninja -vC "${BUILD_DIR}" check-cxx
+
+    step "Running the libc++abi tests"
+    ninja -vC "${BUILD_DIR}" check-cxxabi
 ;;
 #
 # Module builds

``````````

</details>


https://github.com/llvm/llvm-project/pull/193822